Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add comparison to docs#1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bpmct merged 8 commits intomainfrombpmct/comparison
May 10, 2022
Merged

feat: add comparison to docs#1315

bpmct merged 8 commits intomainfrombpmct/comparison
May 10, 2022

Conversation

bpmct
Copy link
Member

This PR adds a comparison for Coder vs similar projects

Fixes#1304

@bpmctbpmct requested review fromkylecarbs andkhorne3May 5, 2022 23:02
@bpmctbpmct self-assigned thisMay 5, 2022
@codecov
Copy link

codecovbot commentedMay 5, 2022•
edited
Loading

Codecov Report

Merging#1315 (b69f600) intomain (47f1fd5) willincrease coverage by0.10%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #1315      +/-   ##==========================================+ Coverage   66.75%   66.85%   +0.10%==========================================  Files         286      282       -4       Lines       18693    18493     -200       Branches      235      235              ==========================================- Hits        12478    12364     -114+ Misses       4931     4865      -66+ Partials     1284     1264      -20
FlagCoverage Δ
unittest-go-macos-latest54.08% <ø> (+0.04%)⬆️
unittest-go-postgres-65.48% <ø> (+0.04%)⬆️
unittest-go-ubuntu-latest56.44% <ø> (+0.01%)⬆️
unittest-go-windows-2022?
unittest-js73.67% <ø> (ø)
Impacted FilesCoverage Δ
cli/configssh.go62.58% <0.00%> (-6.48%)⬇️
pty/ptytest/ptytest.go86.95% <0.00%> (-4.35%)⬇️
cli/templateinit.go58.62% <0.00%> (-3.45%)⬇️
agent/agent.go64.66% <0.00%> (-1.24%)⬇️
coderd/workspaceagents.go55.34% <0.00%> (-0.70%)⬇️
provisioner/terraform/provision.go71.89% <0.00%> (-0.41%)⬇️
provisioner/echo/serve.go56.80% <0.00%> (ø)
pty/start_windows.go
agent/usershell/usershell_windows.go
pty/pty_windows.go
... and9 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update47f1fd5...b69f600. Read thecomment docs.

@bpmctbpmct changed the titlefeat: add comparisonfeat: add comparison to docsMay 6, 2022
Copy link
Contributor

@khorne3khorne3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

minor edits

bpmct reacted with thumbs up emoji
bpmctand others added3 commitsMay 6, 2022 11:59
Co-authored-by: Katie Horne <katie@23spoons.com>
Co-authored-by: Katie Horne <katie@23spoons.com>
Co-authored-by: Katie Horne <katie@23spoons.com>
@bpmctbpmct requested a review fromammarioMay 6, 2022 16:59
@bpmctbpmctenabled auto-merge (squash)May 10, 2022 16:20
@bpmctbpmct merged commite8e4cf9 intomainMay 10, 2022
@bpmctbpmct deleted the bpmct/comparison branchMay 10, 2022 16:32
Copy link
Member

@ammarioammario left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ugh.. I forgot to submit my review@bpmct. No worries, I'll submit commits later.

docs/about.md Outdated


| Tool | Type | Self-hosted version | Hosted version | Availability | Supported platforms |
| :------------------------------------------------------------------ | :---------------------------------- | :--------------------------- | :------------- | :------------------------------ | :--------------------------------------------------------------------------------------------------------------------------------------------------------- |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is important enough to be in the README–just the table though–the preceding text is too much for the README.

Anmol did this withnhooyr/websocket andcoder/slog, which greatly helped their successes.

docs/about.md Outdated
Please file [an issue](https://github.com/coder/coder/issues/new) if any information is out of date. Also refer to: [What Coder is not](./about.md#what-coder-is-not).


| Tool | Type | Self-hosted version | Hosted version | Availability | Supported platforms |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I thinktype can be removed and we remove the Web IDEs

docs/about.md Outdated
| :------------------------------------------------------------------ | :---------------------------------- | :--------------------------- | :------------- | :------------------------------ | :--------------------------------------------------------------------------------------------------------------------------------------------------------- |
| [Coder](https://github.com/coder/coder) | Platform: multiple workspaces and teams | ✅ | | Open source (paid version soon) | All [Terraform](https://www.terraform.io/registry/providers) resources, all clouds, multi-architecture: Linux, Mac, Windows, containers, VMs, amd64, arm64 |
| [Coder (Classic)](https://coder.com/docs) | Platform: multiple workspaces and teams | ✅ | | Proprietary/paid license | Any Kubernetes cluster: Linux Containers |
| [GitHub Codespaces](https://github.com/features/codespaces) | Platform: solo or team | Only GitHub Enterprise Cloud | ✅ | Open source/paid | Linux containers |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

GitHub Enterprise Cloud is not self-hosted.
GitHub Codespaces is not open source either, we should just label it as "Free/Paid SaaS".

@missknissmisskniss added this to theV2 Beta milestoneMay 15, 2022
kylecarbs pushed a commit that referenced this pull requestJun 10, 2022
* fix typo* feat: add comparison table* Update docs/about.mdCo-authored-by: Katie Horne <katie@23spoons.com>* Update docs/about.mdCo-authored-by: Katie Horne <katie@23spoons.com>* Update docs/about.mdCo-authored-by: Katie Horne <katie@23spoons.com>* chore: remove gitpodCo-authored-by: Katie Horne <katie@23spoons.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ammarioammarioammario left review comments

@khorne3khorne3khorne3 approved these changes

@kylecarbskylecarbsAwaiting requested review from kylecarbs

Assignees

@bpmctbpmct

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

README has Comparison section for switch to public
4 participants
@bpmct@ammario@khorne3@misskniss
[8]ページ先頭
©2009-2025 Movatter.jp