Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add audit exporting and filtering#1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
coadler merged 6 commits intomainfromcolin/audit-exporter
May 9, 2022
Merged

Conversation

coadler
Copy link
Contributor

Resolves#469

@coadlercoadler self-assigned thisMay 5, 2022
@coadlercoadler requested a review fromkylecarbsMay 5, 2022 22:26
@codecov
Copy link

codecovbot commentedMay 5, 2022
edited
Loading

Codecov Report

Merging#1314 (435940a) intomain (ac27f64) willdecrease coverage by0.16%.
The diff coverage is70.31%.

@@            Coverage Diff             @@##             main    #1314      +/-   ##==========================================- Coverage   66.49%   66.33%   -0.17%==========================================  Files         284      284                Lines       18593    18456     -137       Branches      235      235              ==========================================- Hits        12364    12242     -122+ Misses       4962     4954       -8+ Partials     1267     1260       -7
FlagCoverage Δ
unittest-go-macos-latest53.71% <70.31%> (+0.10%)⬆️
unittest-go-postgres-65.16% <70.31%> (-0.08%)⬇️
unittest-go-ubuntu-latest56.12% <70.31%> (+0.04%)⬆️
unittest-go-windows-2022?
unittest-js73.67% <ø> (ø)
Impacted FilesCoverage Δ
coderd/database/queries.sql.go78.14% <0.00%> (ø)
coderd/audit/exporter.go60.00% <60.00%> (ø)
coderd/audit/backends/postgres.go69.23% <69.23%> (ø)
coderd/audit/backends/slog.go83.33% <83.33%> (ø)
coderd/audit/filter.go100.00% <100.00%> (ø)
provisionersdk/serve.go35.13% <0.00%> (-8.11%)⬇️
cli/configssh.go62.04% <0.00%> (-6.57%)⬇️
pty/ptytest/ptytest.go86.95% <0.00%> (-4.35%)⬇️
cli/templateinit.go58.62% <0.00%> (-3.45%)⬇️
provisioner/echo/serve.go54.40% <0.00%> (-2.40%)⬇️
... and10 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updateac27f64...435940a. Read thecomment docs.

Copy link
Member

@kylecarbskylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is anextremely clean package. Bravo 👏

@coadlercoadlerenabled auto-merge (squash)May 9, 2022 21:58
@coadlercoadler merged commit20caee1 intomainMay 9, 2022
@coadlercoadler deleted the colin/audit-exporter branchMay 9, 2022 22:05
@missknissmisskniss added this to theV2 Beta milestoneMay 15, 2022
kylecarbs pushed a commit that referenced this pull requestJun 10, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kylecarbskylecarbskylecarbs approved these changes

Assignees

@coadlercoadler

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

Create generic filter system to allow us to only export some audit logs
3 participants
@coadler@kylecarbs@misskniss

[8]ページ先頭

©2009-2025 Movatter.jp