Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: ensure signing out cannot cause any runtime render errors#13137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Parkreiner merged 21 commits intomainfrommes/login-fix
May 3, 2024
Merged
Changes from1 commit
Commits
Show all changes
21 commits
Select commitHold shift + click to select a range
4da94ef
fix: remove some of the jank around our core App component
ParkreinerMay 2, 2024
9986024
refactor: scope navigation logic more aggressively
ParkreinerMay 2, 2024
7004c9c
refactor: add explicit return type to useAuthenticated
ParkreinerMay 2, 2024
ebfaec5
refactor: clean up ProxyContext code
ParkreinerMay 2, 2024
1192eb3
wip: add code for consolidating the HTML metadata
ParkreinerMay 2, 2024
bbe2ae0
refactor: clean up hook logic
ParkreinerMay 2, 2024
1c41937
refactor: rename useHtmlMetadata to useEmbeddedMetadata
ParkreinerMay 2, 2024
79e9c45
fix: correct names that weren't updated
ParkreinerMay 2, 2024
81f2cd9
fix: update type-safety of useEmbeddedMetadata further
ParkreinerMay 2, 2024
390418f
wip: switch codebase to use metadata hook
ParkreinerMay 3, 2024
486f292
Merge branch 'main' into mes/login-fix
ParkreinerMay 3, 2024
b77af73
Merge branch 'mes/login-fix' of https://github.com/coder/coder into m…
ParkreinerMay 3, 2024
e072f7a
refactor: simplify design of metadata hook
ParkreinerMay 3, 2024
2a58322
fix: update stray type mismatches
ParkreinerMay 3, 2024
b55abb7
fix: more type fixing
ParkreinerMay 3, 2024
c45e1b7
fix: resolve illegal invocation error
ParkreinerMay 3, 2024
2a63c1d
fix: get metadata issue resolved
ParkreinerMay 3, 2024
4d3b155
fix: update comments
ParkreinerMay 3, 2024
8067e77
chore: add unit tests for MetadataManager
ParkreinerMay 3, 2024
5e6e974
fix: beef up tests
ParkreinerMay 3, 2024
772b96f
fix: update typo in tests
ParkreinerMay 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
refactor: clean up hook logic
  • Loading branch information
@Parkreiner
Parkreiner committedMay 2, 2024
commitbbe2ae0a6f686f20a63bdeb6c1857ef83160cb84
18 changes: 10 additions & 8 deletionssite/src/hooks/useHtmlMetadata.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,10 @@ import type {
* This is the set of values that are currently being exposed to the React
* application during production. These values are embedded via the Go server,
* so they will never exist when using a JavaScript runtime for the backend
*
* If you need to add a new type of metadata value, add a new property to the
* type alias here, and then rest of the file should light up with errors for
* what else needs to be adjusted
*/
type SourceHtmlMetadata = Readonly<{
user: User;
Expand DownExpand Up@@ -106,17 +110,15 @@ export class MetadataManager implements MetadataManagerApi {
return;
}

const metadataNode = this.trackedMetadataNodes.get(key);
metadataNode?.remove();
this.trackedMetadataNodes.delete(key);

this.metadata = {
...this.metadata,
[key]: undefined,
};

const metadataNode = this.trackedMetadataNodes.get(key);
if (metadataNode !== undefined) {
metadataNode.remove();
this.trackedMetadataNodes.delete(key);
}

this.notifySubscriptionsOfStateChange();
};
}
Expand All@@ -140,14 +142,14 @@ export function makeUseHtmlMetadata(
manager.getMetadata,
);

constresult = useMemo<UseHtmlMetadataResult>(() => {
conststableMetadataResult = useMemo<UseHtmlMetadataResult>(() => {
return {
metadata,
clearMetadataByKey: manager.clearMetadataByKey,
};
}, [metadata]);

returnresult;
returnstableMetadataResult;
};
}

Expand Down

[8]ページ先頭

©2009-2025 Movatter.jp