- Notifications
You must be signed in to change notification settings - Fork928
fix: ensure signing out cannot cause any runtime render errors#13137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
21 commits Select commitHold shift + click to select a range
4da94ef
fix: remove some of the jank around our core App component
Parkreiner9986024
refactor: scope navigation logic more aggressively
Parkreiner7004c9c
refactor: add explicit return type to useAuthenticated
Parkreinerebfaec5
refactor: clean up ProxyContext code
Parkreiner1192eb3
wip: add code for consolidating the HTML metadata
Parkreinerbbe2ae0
refactor: clean up hook logic
Parkreiner1c41937
refactor: rename useHtmlMetadata to useEmbeddedMetadata
Parkreiner79e9c45
fix: correct names that weren't updated
Parkreiner81f2cd9
fix: update type-safety of useEmbeddedMetadata further
Parkreiner390418f
wip: switch codebase to use metadata hook
Parkreiner486f292
Merge branch 'main' into mes/login-fix
Parkreinerb77af73
Merge branch 'mes/login-fix' of https://github.com/coder/coder into m…
Parkreinere072f7a
refactor: simplify design of metadata hook
Parkreiner2a58322
fix: update stray type mismatches
Parkreinerb55abb7
fix: more type fixing
Parkreinerc45e1b7
fix: resolve illegal invocation error
Parkreiner2a63c1d
fix: get metadata issue resolved
Parkreiner4d3b155
fix: update comments
Parkreiner8067e77
chore: add unit tests for MetadataManager
Parkreiner5e6e974
fix: beef up tests
Parkreiner772b96f
fix: update typo in tests
ParkreinerFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
fix: update stray type mismatches
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit2a5832267a25c46b135cf199d41822f21bd9d10c
There are no files selected for viewing
4 changes: 2 additions & 2 deletionssite/src/hooks/useEmbeddedMetadata.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.