- Notifications
You must be signed in to change notification settings - Fork928
chore: add docs for sharing ports#13136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Great addition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I made some minor copy changes and promoted all the new headers to allow "Configure maximum port sharing level" to render theenterprise label.
Before:
After:
Uh oh!
There was an error while loading.Please reload this page.
After taking a look at our existing documentation, it made the most sense (to me personally) to add what we have drafted to the existing Port Forwarding docs. I know this page is very long, but I think this page should probably be looked at holistically in a separate effort to re-organize this docs page.
@stirby I left a few redundant images out and moved things around slightly, feel free to dive into this and make suggestions or changes as you see fit directly to the PR if you'd like.
Todos: