- Notifications
You must be signed in to change notification settings - Fork928
feat: move shared ports out of experiment#13120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
| if len(codersdk.ExperimentsAll) == 0 { | ||
| t.Skip("No experiments are currently defined; skipping test.") | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@dannykopping I see these prom metrics are somewhat assuming that thelen(codersdk.ExperimentsAll) will always be at least > 0, but with the removal of shared ports we currently have an empty slice for it and it's failing these tests. Let me know if you'd like me to do something besides skipping these under that condition in this PR. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We spoke offline, he gave me the 👍 for now and we'll make the changes to get these tests running again soon.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Transition looks good.
Uh oh!
There was an error while loading.Please reload this page.
Completes part of#13058
Before with no experiment enabled:
After with enterprise license:
After without license:
