NotificationsYou must be signed in to change notification settings
Fork927
Star10.1k

fix: Restore terminal on interrupt when connecting#1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

kylecarbs merged 1 commit intomainfromrestoreterm

May 6, 2022

Merged

fix: Restore terminal on interrupt when connecting#1312

kylecarbs merged 1 commit intomainfromrestoreterm

May 6, 2022

Conversation

Copy link

Member

kylecarbs commentedMay 5, 2022

Fixes#1292.

kylecarbs requested a review fromcoadler

May 5, 2022 21:25

kylecarbs self-assigned this

May 5, 2022

coadler approved these changes

May 5, 2022

View reviewed changes

Copy link

codecovbot commentedMay 5, 2022•
edited
Loading

Codecov Report

Merging#1312 (22a709b) intomain (568574c) willdecrease coverage by0.00%.
The diff coverage is66.66%.

@@            Coverage Diff             @@##             main    #1312      +/-   ##==========================================- Coverage   66.18%   66.18%   -0.01%==========================================  Files         281      281                Lines       18424    18438      +14       Branches      220      220              ==========================================+ Hits        12194    12203       +9- Misses       4971     4976       +5  Partials     1259     1259

Flag	Coverage Δ
unittest-go-macos-latest	`53.50% <66.66%> (-0.04%)`	⬇️
unittest-go-postgres-	`65.01% <66.66%> (-0.07%)`	⬇️
unittest-go-ubuntu-latest	`55.94% <66.66%> (-0.02%)`	⬇️
unittest-go-windows-2022	`51.92% <66.66%> (-0.01%)`	⬇️
unittest-js	`71.61% <ø> (ø)`

Impacted Files	Coverage Δ
cli/cliui/agent.go	`77.46% <64.28%> (+0.27%)`	⬆️
provisionerd/provisionerd.go	`76.17% <100.00%> (-0.54%)`	⬇️
provisioner/echo/serve.go	`56.80% <0.00%> (-2.41%)`	⬇️
coderd/provisionerdaemons.go	`62.98% <0.00%> (-0.51%)`	⬇️
peer/channel.go	`85.96% <0.00%> (ø)`
provisioner/terraform/provision.go	`72.30% <0.00%> (+0.40%)`	⬆️
peer/conn.go	`81.57% <0.00%> (+0.73%)`	⬆️
provisionersdk/serve.go	`43.24% <0.00%> (+8.10%)`	⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update568574c...22a709b. Read thecomment docs.