- Notifications
You must be signed in to change notification settings - Fork929
feat: Implement unified pagination and add template versions support#1308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
mafredri merged 21 commits intomainfrommafredri/feat-paginate-template-versions-endpointMay 10, 2022
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
21 commits Select commitHold shift + click to select a range
475dcf9
feat: Implement pagination for template versions
mafredri01a52d1
Use codersdk.Pagination in users endpoint
mafredrid1478a9
Avoid user sort side-effect in databasefake
mafredri7a36610
Return sql.ErrNoRows for GetUsers in databasefake
mafredri61c60c6
Sync codepaths in databasefake
mafredri62fa273
Fix test with better handling of sql.ErrNoRows in coderd
mafredri878d633
Remove an unused require.NoError
mafredri5c840fd
Return empty list for sql.ErrNoRows in coderd users endpoint
mafredri07e590c
Add t.Parallel() to sub tests
mafredribe8ba6c
Reinit tt due to parallel test
mafredri5ab9ad5
Remove unused variable
mafredrie2a3741
Fix copy pasta in query comments
mafredri61410a5
Move ParsePagination from httpapi to coderd and unexport, return code…
mafredri8a67746
codersdk: Create requestOption type
mafredri55028d2
codersdk: Add test for Pagination.asRequestOption
mafredriea2371e
coderd: Handle http response errors in parsePagination
mafredri66af4ec
codersdk: Use parallel test
mafredri067f912
Fix created_at edge case for pagination cursor in queries
mafredrib8be7a8
Fix copy paste issue
mafredri13fc406
Run make gen
mafredriaab400c
feat: Add support for json omitempty and embedded structs in apitypin…
mafredriFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
codersdk: Create requestOption type
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit8a67746c152f673ce6cc5546b89a75eaa14a3ad5
There are no files selected for viewing
4 changes: 3 additions & 1 deletioncodersdk/client.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletioncodersdk/pagination.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.