NotificationsYou must be signed in to change notification settings
Fork927
Star10.1k

ci: release: test migrations before building#13051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

johnstcn merged 4 commits intomainfromcj/fixup-makefile-test-migrations

Apr 24, 2024

Merged

ci: release: test migrations before building#13051

johnstcn merged 4 commits intomainfromcj/fixup-makefile-test-migrations

Apr 24, 2024

Conversation

Copy link

Member

johnstcn commentedApr 23, 2024

Adds step to test migrations before releasing.
Modifiestest-migrations target to avoid usingmigrate-ci

johnstcn added2 commits

April 23, 2024 13:04

fix(Makefile): test-migrations: remove usage of migrate-ci

b10c6f9

ci: release: test migrations before building

e314886

johnstcn self-assigned this

Apr 23, 2024

johnstcn requested review frommafredri,mtojek anddeansheather

April 23, 2024 12:06

deansheather reviewed

Apr 23, 2024

View reviewed changes

Copy link

Member

deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Does this work when testing cherry pick releases?

Makefile OutdatedShow resolvedHide resolved

fixup! fix(Makefile): test-migrations: remove usage of migrate-ci

d580929

Copy link

MemberAuthor

johnstcn commentedApr 23, 2024

Does this work when testing cherry pick releases?

The script stands up a test database, runs the migrations from$COMMIT_FROM, runs the migrations from$COMMIT_TO, dumps the schema, and diffs it against$COMMIT_TO:dump.sql.
I don't think it should make any difference between a cherry-picked commit or not.