- Notifications
You must be signed in to change notification settings - Fork928
chore(docs): add k8s terraform link to k8s installation docs#13040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ericpaulsen approved these changesApr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
thank you!@doodzik
@doodzik can you run |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Hello from Georgian again.
I've set up a GKE cluster for Coder with Terraform. The setup would have been much less work if I had known Terraform scripts were available. I copied the link from theCoder README pointing to your Terraform scripts and added it to the k8s installation guide. This will make it much easier to discover for someone who wants to install Coder on k8s.
As a side note, the link to the Terraform repo points to a user unaffiliated with Coder. This is a security risk because you don't control that repo. To fix this issue in the longer term, I would suggest creating a repo with Terraform scripts in your Coder organization.
\cc@ericpaulsen