- Notifications
You must be signed in to change notification settings - Fork927
feat: show version on login page#13033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -24,7 +24,7 @@ export const AgentVersion: FC<AgentVersionProps> = ({ | |||
| ); | |||
| if (status === agentVersionStatus.Updated) { | |||
| return<span>Updated</span>; | |||
| returnnull; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Just checking if we want to do this since this looks to be outside of the scope.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
sneaking in out of scope things is my favorite 😝 but yes, this was intentional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM! Nice work.
matifali commentedApr 23, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The issue request is to show the version in the dashboard footer on all pages all the time. |
the internal issue specifically mentions the login page, so I went with that. adding it to all of the other pages will be a more involved change anyway, so I'm gonna merge this as is, but if we really want it everywhere, I can do another pr later. |
Closes#12909