Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

refactor(site): reorganize template schedule settings form#13031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 2 commits intomainfrombq/reorganize-schedule-settings
Apr 23, 2024

Conversation

BrunoQuaresma
Copy link
Collaborator

Close#12617

Demo

Screen.Recording.2024-04-22.at.10.04.27.mov

Autostop
Image

Autostart
Image

Dormancy
Image

MrPeacockNLB reacted with thumbs up emojistirby reacted with hooray emoji
@BrunoQuaresmaBrunoQuaresma requested a review froma teamApril 22, 2024 17:03
@BrunoQuaresmaBrunoQuaresma self-assigned thisApr 22, 2024
@BrunoQuaresmaBrunoQuaresma requested review fromParkreiner and removed request fora teamApril 22, 2024 17:03
Copy link
Member

@ParkreinerParkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks really good! Mainly had a suggestion about tidying up the UI a bit more:
https://www.chromatic.com/test?appId=624de63c6aacee003aa84340&id=662698f790e6752a83fb903a

@BrunoQuaresmaGraphite App
Copy link
CollaboratorAuthor

Looks really good! Mainly had a suggestion about tidying up the UI a bit more:
https://www.chromatic.com/test?appId=624de63c6aacee003aa84340&id=662698f790e6752a83fb903a

I agree with your suggestions but I think it is out of the scope of this issue so I created an issue to track this improvement#13050. I plan to work on it on the "free" week.

@BrunoQuaresmaBrunoQuaresma merged commit2f7f9d0 intomainApr 23, 2024
@BrunoQuaresmaBrunoQuaresma deleted the bq/reorganize-schedule-settings branchApril 23, 2024 11:59
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 23, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ParkreinerParkreinerParkreiner approved these changes

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Template schedule settings page reorganization
2 participants
@BrunoQuaresma@Parkreiner
[8]ページ先頭
©2009-2025 Movatter.jp