Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore(docs): add note regarding vcredist for embedded postgres#13020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 2 commits intomainfromcj/docs-windows-vcredist
Apr 26, 2024

Conversation

johnstcn
Copy link
Member

Relates to#13010

Adds a note regarding vcredist. Some Windows cloud images do not ship with this pre-installed.

@johnstcnjohnstcn self-assigned thisApr 22, 2024
Copy link
Member

@kylecarbskylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@johnstcn can we easily detect this? It'd be a better experience.

@kylecarbs
Copy link
Member

@kylecarbs
Copy link
Member

@johnstcn seems like we could also just implement this ourselves super easily instead of using a library. I think that's more helpful than including it in the docs.

@johnstcn
Copy link
MemberAuthor

johnstcn commentedApr 22, 2024
edited
Loading

@johnstcn seems like we could also just implement this ourselves super easily instead of using a library. I think that's more helpful than including it in the docs.

To clarify, you are proposing that we detect the absence of the VC++ redist libraries if using embedded postgres on windows, and log a message?

@johnstcn
Copy link
MemberAuthor

I'm going to go ahead and merge this; will address Kyle's suggestion in a separate PR.

@johnstcnjohnstcn merged commitf1ef9fd intomainApr 26, 2024
@johnstcnjohnstcn deleted the cj/docs-windows-vcredist branchApril 26, 2024 09:56
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 26, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@kylecarbskylecarbskylecarbs left review comments

@matifalimatifalimatifali approved these changes

Assignees

@johnstcnjohnstcn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: windows:coder server fails to start due to missing vcredist libraries

3 participants

@johnstcn@kylecarbs@matifali

[8]ページ先頭

©2009-2025 Movatter.jp