- Notifications
You must be signed in to change notification settings - Fork1k
chore(docs): add note regarding vcredist for embedded postgres#13020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@johnstcn can we easily detect this? It'd be a better experience.
There's this package:https://github.com/noneymous/go-redistributable-checker |
@johnstcn seems like we could also just implement this ourselves super easily instead of using a library. I think that's more helpful than including it in the docs. |
johnstcn commentedApr 22, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
To clarify, you are proposing that we detect the absence of the VC++ redist libraries if using embedded postgres on windows, and log a message? |
I'm going to go ahead and merge this; will address Kyle's suggestion in a separate PR. |
Relates to#13010
Adds a note regarding vcredist. Some Windows cloud images do not ship with this pre-installed.