Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: make terminal raw in ssh command on windows#12990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
deansheather merged 2 commits intomainfromdean/ssh-windows-raw
Apr 17, 2024

Conversation

deansheather
Copy link
Member

@deansheatherdeansheather commentedApr 17, 2024•
edited
Loading

We were making it raw, but not raw enough. It needs a few extra modes enabled to function with arrows etc.

Code taken from Coder v1 where we had the same problem.

Tested manually on both Linux and Windows to ensure that left and right arrows work when editing the prompt, htop works (arrow keys, mouse clicks, escape key), resizing works.

MrPeacockNLB reacted with hooray emoji
We were making it raw, but not raw enough. It needs a few extra modesenabled to function with arrows etc.
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Didn't test this but code looks otherwise alright 👍🏻.

@deansheather
Copy link
MemberAuthor

deansheather commentedApr 17, 2024•
edited
Loading

Moved the files to pty package and changed it so there's only one set public function for all platforms.

Re-tested

Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice!

@deansheatherdeansheatherenabled auto-merge (squash)April 17, 2024 17:56
@MrPeacockNLB
Copy link
Contributor

Wow sounds nice! Can not await to test

@deansheatherdeansheather merged commitd426569 intomainApr 17, 2024
@deansheatherdeansheather deleted the dean/ssh-windows-raw branchApril 17, 2024 18:01
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 17, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@kylecarbskylecarbskylecarbs left review comments

@mafredrimafredrimafredri approved these changes

Assignees

@deansheatherdeansheather

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@deansheather@MrPeacockNLB@mafredri@kylecarbs
[8]ページ先頭
©2009-2025 Movatter.jp