- Notifications
You must be signed in to change notification settings - Fork928
fix: add grace period before showing replicas license error#12989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This should probably be fine in most cases.
If folks modify the defaultreadinessProbe such that new pods take more than 60 seconds to become ready, they may end up seeing the warning.
Maybe we could tie the grace period to the entitlements check interval? That way, if a replica stays up for an entire license check interval, we would have a pretty clear signal. |
@johnstcn I wanted to keep the values separated for now, just so it's easier to test and understand. |
Fixes#8665.