- Notifications
You must be signed in to change notification settings - Fork928
refactor(site): verify deployment config flags in e2e tests#12986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, one potentially unrelated change appears to have snuck in.
site/e2e/playwright.config.ts Outdated
| ], | ||
| reporter: [["./reporter.ts"]], | ||
| //reporter: [["./reporter.ts"]], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is this part of the change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good catch! I had to remove it.
Uh oh!
There was an error while loading.Please reload this page.
Related:#12508
This PR slices the config flag verification function into a set of type-dedicated functions so that e2e test has more control over a verified type.