Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: deprecate gauge metrics with _total suffix (#12744)#12976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
matifali merged 3 commits intocoder:mainfromsnark87:deprecated-metrics
Apr 24, 2024

Conversation

snark87
Copy link
Contributor

@snark87snark87 commentedApr 16, 2024•
edited
Loading

Fixes#12744

Deprecated metrics:

  • coderd_oauth2_external_requests_rate_limit_total
  • coderd_api_workspace_latest_build_total

@cdr-botcdr-botbot added the communityPull Requests and issues created by the community. labelApr 16, 2024
Deprecated metrics:- coderd_oauth2_external_requests_rate_limit_total- coderd_api_workspace_latest_build_total
@snark87snark87 marked this pull request as ready for reviewApril 18, 2024 04:30
Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great work@snark87! Thank you very much for your contribution

Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice work! Created a follow-up issue to track deprecation.

@johnstcn
Copy link
Member

@snark87 can you please merge latest main? There's an issue with one of the tests that has been worked around here:coder/internal#101

snark87and others added2 commitsApril 18, 2024 14:10
add link to follow-up issueCo-authored-by: Cian Johnston <public@cianjohnston.ie>
@snark87
Copy link
ContributorAuthor

snark87 commentedApr 18, 2024•
edited
Loading

@snark87 can you please merge latest main? There's an issue with one of the tests that has been worked around here:coder/internal#101
@johnstcn Done, CI is green now.

@matifalimatifali merged commit4682355 intocoder:mainApr 24, 2024
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 24, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@dannykoppingdannykoppingdannykopping approved these changes

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@snark87snark87

Labels
communityPull Requests and issues created by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate gauge metrics named like counters
4 participants
@snark87@johnstcn@dannykopping@matifali
[8]ページ先頭
©2009-2025 Movatter.jp