Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

test(site): add e2e tests for user auth#12971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mtojek merged 10 commits intomainfrom12508-user-auth
Apr 16, 2024
Merged

test(site): add e2e tests for user auth#12971

mtojek merged 10 commits intomainfrom12508-user-auth
Apr 16, 2024

Conversation

mtojek
Copy link
Member

@mtojekmtojek commentedApr 16, 2024
edited
Loading

Related:#12508

This PR adds e2e tests for user authentication config.

@mtojekmtojek self-assigned thisApr 16, 2024
@mtojekmtojek mentioned this pull requestApr 16, 2024
@mtojekmtojek marked this pull request as ready for reviewApril 16, 2024 11:35
@mtojekmtojek requested a review fromjohnstcnApril 16, 2024 11:35
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Non-blocking: I'm somewhat worried about all of the test logic getting stuffed intoverifyConfigFlag. Any other special cases will also need to get stuffed in there.

I wonder if we could instead refactorverifyConfigFlag to accept a function that takes a function as an argument. This function should just run whatever assertions are necessary for the particular config flag.

Then the responsibility for asserting the content of the node moves back up to the test instead of in this function, e.g.

  verifyConfigFlag(page, config, flag, (configOpt) -> { expect(configOpt.locator(`...`)).toBeVisible()  })

andverifyConfigFlag is just concerned with finding the relevant option on the page and passing it to the function.

WDYT?

@mtojek
Copy link
MemberAuthor

I agree, this is a reasonable idea, although I wouldn't pack refactoring here. I refactor the logic in the follow-up to this PR. Thanks for the review 👍

@mtojekmtojek merged commitb598aef intomainApr 16, 2024
@mtojekmtojek deleted the 12508-user-auth branchApril 16, 2024 12:32
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 16, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@mtojekmtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@mtojek@johnstcn

[8]ページ先頭

©2009-2025 Movatter.jp