Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(docs): make external auth docs easier to follow#12970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kylecarbs merged 5 commits intocoder:mainfromdoodzik:main
Apr 20, 2024

Conversation

doodzik
Copy link
Contributor

I was working with@ericpaulsen on setting up Coder. I found the external auth documentation confusing for a first-time reader, so I changed the docs a tiny bit to make it easier to follow.

I also added a k8s environment variable setup section because converting the environment variable to the k8s environment variables was annoying. Now, it can be copy and pasted.

@ericpaulsen, In our call you mentioned that you prefer using GitHub OAuth applications for external auth. Would you like me to switch the docs to use the OAuth application setup proccess instead of the GitHub App one?

@cdr-botcdr-botbot added the communityPull Requests and issues created by the community. labelApr 16, 2024
@github-actionsGitHub Actions
Copy link

github-actionsbot commentedApr 16, 2024•
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@doodzikdoodzik changed the titleadd additional context to github external auth provider documentationchore(docs): make external auth docs easier to followApr 16, 2024
@doodzik
Copy link
ContributorAuthor

I have read the CLA Document and I hereby sign the CLA

cdrcommunity added a commit to coder/cla that referenced this pull requestApr 16, 2024
Copy link
Member

@kylecarbskylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for this! It's certainly easier to read through now.

Just a few minor edits, nothing major. Maybe we putUSER_DEFINED in<> to be even more explicit?

doodzik reacted with rocket emoji
Co-authored-by: Kyle Carberry <kyle@carberry.com>
@doodzik
Copy link
ContributorAuthor

doodzik commentedApr 16, 2024•
edited
Loading

@kylecarbs great suggestions! I applied them 👍

I also changedUSER_DEFINED toUSER_DEFINED_ID because it made it a bit more explicit when used throughout the document.

kylecarbs reacted with thumbs up emoji

Copy link
Member

@kylecarbskylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Awesome, thanks!

@ericpaulsen
Copy link
Member

@doodzik thank you for this contribution! let's keep the GitHub App flow for now, it's working well from my testing.

doodzik reacted with thumbs up emojidoodzik reacted with rocket emoji

@kylecarbs
Copy link
Member

kylecarbs commentedApr 17, 2024•
edited
Loading

@doodzik could you apply this patch to fix the formatting?

https://gist.github.com/kylecarbs/9787881a96bd75aaba7a261610390b89

@doodzik
Copy link
ContributorAuthor

doodzik commentedApr 19, 2024•
edited
Loading

@kylecarbs Applied the diff. Can you run the CI step again?

ericpaulsen reacted with thumbs up emoji

@kylecarbskylecarbsenabled auto-merge (squash)April 20, 2024 16:23
@kylecarbskylecarbs merged commitb40f54f intocoder:mainApr 20, 2024
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 20, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@kylecarbskylecarbskylecarbs approved these changes

Assignees

@doodzikdoodzik

Labels
communityPull Requests and issues created by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@doodzik@ericpaulsen@kylecarbs
[8]ページ先頭
©2009-2025 Movatter.jp