- Notifications
You must be signed in to change notification settings - Fork927
feat(cli): support bundle: dump healthcheck summary#12963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
| type WebsocketReport struct { | ||
| // Healthy is deprecated and left for backward compatibility purposes, use `Severity` instead. | ||
| Healthy bool `json:"healthy"` | ||
| Severity health.Severity `json:"severity" enums:"ok,warning,error"` | ||
| Warnings []string `json:"warnings"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
review: this is technically a breaking change... but it should have been this way from the beginning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice 👍 👍
Uh oh!
There was an error while loading.Please reload this page.
(From comment in#12951 (comment))
This PR modifies the
support bundlecommand to dump a summary of deployment health and the CLI netcheck to stdout, when run:Note: I introduced the
BaseReportas a way to avoid writing five or six differentSummarize()methods.