Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add warning about use of old/removed/invalid experiments#12962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dannykopping merged 14 commits intocoder:mainfromdannykopping:dk/old-exps
Apr 17, 2024

Conversation

dannykopping
Copy link
Contributor

@dannykoppingdannykopping commentedApr 15, 2024•
edited
Loading

Fixes#12725

image

If one of the FE folks could help me refactorsite/src/pages/DeploySettingsPage/Option.tsx andsite/src/pages/DeploySettingsPage/optionValue.ts to allow another boolean indicating whether an experiment is invalid or not, we could change the display of enabled experiments to indicate invalid ones as well. I tried various attempts at this but my lack of TS knowledge is hindering me.

I changed theCheckCircleOutlined toLabelImportant because a check indicates that it is valid, where really we just want to display that it's enabled. We could leave it like this IMHO but doing the above would be more user-friendly.

I haven't done frontend in avery long time so please forgive any glaringly obvious violations of good practice and point them out to me so I can improve them.

matifali and Kira-Pilot reacted with heart emoji
@dannykoppingdannykopping changed the titleWarn about using old/removed/invalid experimentsenhancement: warn about using old/removed/invalid experimentsApr 15, 2024
@dannykoppingdannykopping changed the titleenhancement: warn about using old/removed/invalid experimentsfeat: warn about using old/removed/invalid experimentsApr 15, 2024
@dannykoppingdannykopping changed the titlefeat: warn about using old/removed/invalid experimentsfeat: add warning about use of old/removed/invalid experimentsApr 15, 2024
@dannykoppingdannykopping marked this pull request as ready for reviewApril 15, 2024 14:40
@johnstcn
Copy link
Member

We already generate the list of all valid experiments viatypesgen, which means we have:

// From codersdk/deployment.goexport type Experiment = "auto-fill-parameters" | "example" | "shared-ports";export const Experiments: Experiment[] = [  "auto-fill-parameters",  "example",  "shared-ports",];

Can we simply just use this to check if an experiment is valid or not?

@dannykopping
Copy link
ContributorAuthor

Oh interesting! I didn't know about that list...
It seems stale though?auto-fill-parameters is not part ofcodersdk.ExperimentsAll. Perhaps I'll add a linter for this and move over to just using that list as the source of truth.

@johnstcn
Copy link
Member

Oh interesting! I didn't know about that list... It seems stale though?auto-fill-parameters is not part ofcodersdk.ExperimentsAll. Perhaps I'll add a linter for this and move over to just using that list as the source of truth.

I think that may be due toauto-fill-parameters not being something we want to include as a "safe" experiment.

Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Replaced green circle with more neutral icon to indicate enabled experimentsSigned-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, but would probably also wait for someone from@fe to review.
Also note: when you make changes, you need to go into Chromatic to accept the new baseline.

dannykopping reacted with heart emoji
@Parkreiner
Copy link
Member

Accidentally published my reviews early – not quite done yet

Copy link
Member

@ParkreinerParkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Had a couple of recommendations, but nothing worth blocking over.

I haven't worked as much with the E2E tests, but if you need help getting that to pass, I'm happy to pair on that

dannykopping reacted with heart emoji
Copy link
Member

@Kira-PilotKira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@Parkreiner already gave a thorough review so I don't have too much to add. I approved your storybooks and the new UI looks nice!@mtojek might be able to help you out with that E2E test; it was added recentlyhere.

dannykopping reacted with heart emoji
Signed-off-by: Danny Kopping <danny@coder.com>
…he previous behaviourSigned-off-by: Danny Kopping <danny@coder.com>
@dannykopping
Copy link
ContributorAuthor

@Parkreiner thanks for the detailed review! I've made your suggested changes plus a couple others.
Would you mind having one last look before I smash thatlike merge button?

Copy link
Member

@ParkreinerParkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Had one last suggestion, but this looks good!

dannykopping reacted with heart emoji
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
@dannykoppingdannykopping merged commitb85d5d8 intocoder:mainApr 17, 2024
@dannykoppingdannykopping deleted the dk/old-exps branchApril 17, 2024 14:59
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 17, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@ParkreinerParkreinerParkreiner approved these changes

@Kira-PilotKira-PilotKira-Pilot approved these changes

@aslilacaslilacAwaiting requested review from aslilac

Assignees

@dannykoppingdannykopping

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warn about using old/removed/invalid experiments
4 participants
@dannykopping@johnstcn@Parkreiner@Kira-Pilot
[8]ページ先頭
©2009-2025 Movatter.jp