- Notifications
You must be signed in to change notification settings - Fork927
fix: label template settings that require an enterprise license appropriately#12952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
since I'll be out next week, feel free to just merge this if you don't have any requested changes :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good!
I do think that we have enoughenabled
properties in the UI that it's starting to make sense to consolidate them into a single object, but that's outside the scope of this PR
I'll go ahead and merge this for you
Uh oh!
There was an error while loading.Please reload this page.
"Require Active Version" is an enterprise feature, that we currently just show as if it's usable, and then ignore on the backend, leading to a frustrating experience when you feel like you just can't enable this feature, seemingly because of a bug.