Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(coderd/healthcheck): improve detection of STUN issues#12951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 13 commits intomainfromcj/stun-diagnose
Apr 15, 2024

Conversation

johnstcn
Copy link
Member

@johnstcnjohnstcn commentedApr 12, 2024•
edited
Loading

Fixes#12165

  • Adds checks tocoderd/healthcheck/derphealth for STUN issues. For now, I'm just checking that there is at least one healthy STUN server, and that we don't see variable port mapping.
  • Support bundle command will now run a netcheck
  • Support bundle command now dumps any errors or warnings from deployment health to stderr. (Edit: this can be a separate PR)

@johnstcnjohnstcn self-assigned thisApr 12, 2024
Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

High level/design review

@johnstcnjohnstcn changed the titlefeat(support): attempt to auto-diagnose STUN issuesfeat(healthcheck): improve detection of STUN issuesApr 15, 2024
@johnstcnjohnstcn changed the titlefeat(healthcheck): improve detection of STUN issuesfeat(coderd/healthcheck): improve detection of STUN issuesApr 15, 2024
@johnstcnjohnstcn merged commit9a4703a intomainApr 15, 2024
@johnstcnjohnstcn deleted the cj/stun-diagnose branchApril 15, 2024 16:10
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 15, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mtojekmtojekmtojek approved these changes

@coadlercoadlerAwaiting requested review from coadler

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: support bundle: automatically diagnose STUN issues in network support bundle
2 participants
@johnstcn@mtojek
[8]ページ先頭
©2009-2025 Movatter.jp