- Notifications
You must be signed in to change notification settings - Fork928
chore: nix shell to support playwright e2e tests#12917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nix is running an older version of chromium, so had to reduce theplaywright version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
couple small things, but overall this is great! thanks for this!
Uh oh!
There was an error while loading.Please reload this page.
| @@ -20,3 +20,26 @@ pnpm playwright:test | |||
| # Run a specific test (`-g` stands for grep. It accepts regex). | |||
| pnpm playwright:test -g '<your test here>' | |||
| ``` | |||
| # Using nix | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think it's probably worth linking tohttps://search.nixos.org/packages?channel=unstable&type=packages&query=playwright-driver somewhere in this section as a quick way to figure out what the "right" Playwright version is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
I bet we could even write a script that gets the version number from nixpkgs, and runs |
Co-authored-by: Kayla Washburn-Love <mckayla@hey.com>
That would be very cool. |
nix is running an older version of chromium, so had to reduce the playwright version.