NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

fix(examples): copy /etc/skel on init in docker template#12913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

mafredri merged 1 commit intomainfrommafredri/fix-examples-docker-user-skel

Apr 9, 2024

Merged

fix(examples): copy /etc/skel on init in docker template#12913

mafredri merged 1 commit intomainfrommafredri/fix-examples-docker-user-skel

Apr 9, 2024

Conversation

Copy link

Member

mafredri commentedApr 9, 2024•
edited
Loading

This will give users a nicer first-time experience using the docker template and will allow them to update their~/.bashrc and it'll just work ™️.

Fixes#10209

Edit: It seems~/.bashrc did work even without this, but this is still a nicer experience with colored prompt/better settings over of a basic black/white one. I only tested in web terminal though so that may be why the rcfile worked even without this PR.

fix(examples): copy /etc/skel on init in docker template

4d4f760

Fixes#10209

github-actionsbot assignedmafredri

Apr 9, 2024

Copy link

MemberAuthor

mafredri commentedApr 9, 2024

fix(examples): copy /etc/skel on init in docker template #12913 👈
main

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@mafredri and the rest of your teammates onGraphite

mafredri marked this pull request as ready for review

April 9, 2024 11:41

mafredri mentioned this pull request

Apr 9, 2024

A new workspace from docker template does not source.bashrc#10209

Closed

mafredri requested review fromjohnstcn andmatifali

April 9, 2024 11:49

johnstcn approved these changes

Apr 9, 2024

View reviewed changes

matifali approved these changes

Apr 9, 2024

View reviewed changes

Copy link

MemberAuthor

mafredri commentedApr 9, 2024

Verified the fix for SSH sessions, here the change is immediately visible.

Fix:

coder@w ~/coder mafredri/fix-examples-docker-user-skel*❯ ./scripts/coder-dev.sh ssh test👋 Your workspace is outdated! Update it here: http://127.0.0.1:3000/@admin/testTo run a command as administrator (user "root"), use "sudo <command>".See "man sudo_root" for details.HELLO WORLDadmin@test:~$

No fix:

coder@w ~/coder mafredri/fix-examples-docker-user-skel* 17s❯ ./scripts/coder-dev.sh ssh test2To run a command as administrator (user "root"), use "sudo <command>".See "man sudo_root" for details.admin@test2:~$ cat ~/.bashrcecho HELLO WORLDadmin@test2:~$