Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: show template autostop setting when it overrides the workspace setting#12910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 4 commits intomainfromk11471
Apr 11, 2024

Conversation

aslilac
Copy link
Member

Closes#11471

@aslilacaslilac changed the titlefix: show template autostop value in workspace settings when customization is disabledfix: show template autostop setting when it overrides the workspace settingApr 8, 2024
@aslilacaslilac marked this pull request as ready for reviewApril 8, 2024 23:30
Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We should just solve this on the backend imo

@aslilacaslilac requested a review fromEmyrkApril 10, 2024 23:00
@aslilac
Copy link
MemberAuthor

if you like this patch more I'll add a test for it

Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yup exactly this. A unit test just to verify would be perfect

@aslilacaslilac requested a review fromEmyrkApril 11, 2024 18:14
@aslilacaslilac merged commit2ad7fcc intomainApr 11, 2024
@aslilacaslilac deleted the k11471 branchApril 11, 2024 19:08
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 11, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@EmyrkEmyrkEmyrk approved these changes

@BrunoQuaresmaBrunoQuaresmaAwaiting requested review from BrunoQuaresma

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workspace Autostop settings displaying incorrect value when template is updated
2 participants
@aslilac@Emyrk

[8]ページ先頭

©2009-2025 Movatter.jp