- Notifications
You must be signed in to change notification settings - Fork928
fix(install.sh): change post-install advisory when installing specific version#12878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
fix(install.sh): change post-install advisory when installing specific version#12878
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@michaelbrewer FYI, this is the improvement I had in mind. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This PR is a hotfix and has been automatically approved.
- ✅ Base is main
- ✅ Has hotfix label
- ✅ Head is from coder/coder
- ✅ Less than 100 lines
Looks like we introduced an unbound variable check in#12873, merging this as a hotfix now. Feel free to post-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
This is a continuation of#12873 to fully support
--versionflag.