Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(site): add e2e tests for groups#12866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 11 commits intomainfrombq/add-e2e-for-create-and-remove-groups
Apr 5, 2024

Conversation

BrunoQuaresma
Copy link
Collaborator

Closes#12506

@BrunoQuaresmaBrunoQuaresma self-assigned thisApr 4, 2024
@BrunoQuaresmaBrunoQuaresma requested review fromcode-asher and removed request fora teamApril 4, 2024 14:59
Copy link
Member

@code-ashercode-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nicely done!

One note, the linked issues mentions testing the everyone group which I am not seeing in here, does that need to be added?

@code-asher
Copy link
Member

One other note actually, since this also includes a bug fix should this be prefixed withfix? Too bad we can only squash and merge otherwise you could merge two commits, a chore and a fix.

@BrunoQuaresma
Copy link
CollaboratorAuthor

One note, the linked issues mentions testing the everyone group which I am not seeing in here, does that need to be added?

Good catch, I will add the everyone group test.

One other note actually, since this also includes a bug fix should this be prefixed with fix? Too bad we can only squash and merge otherwise you could merge two commits, a chore and a fix.

That is true, since most of this PR is chore related, I think we should keep it

@BrunoQuaresmaBrunoQuaresma merged commit3fbcdb0 intomainApr 5, 2024
@BrunoQuaresmaBrunoQuaresma deleted the bq/add-e2e-for-create-and-remove-groups branchApril 5, 2024 00:56
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 5, 2024
@code-asher
Copy link
Member

code-asher commentedApr 5, 2024•
edited
Loading

That is true, since most of this PR is chore related, I think we should keep it

True, just worried it will be missed in the changelog for anyone tracking the bug. For users the fix is important, the chore may just be glossed over.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@code-ashercode-ashercode-asher approved these changes

@dannykoppingdannykoppingAwaiting requested review from dannykopping

@mtojekmtojekAwaiting requested review from mtojek

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

e2e: User/Group management
2 participants
@BrunoQuaresma@code-asher
[8]ページ先頭
©2009-2025 Movatter.jp