- Notifications
You must be signed in to change notification settings - Fork927
feat: Add code splitting to reduce bundle size#1285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This splits our pages to use separate JavaScript bundles. Itinitially splits the terminal, which reduces our primarybundle size by ~400KB.We should do this for all pages, but that can come in a futurechange. This leaves the loading page empty for now, which Ithink is fine. None of our pages are large enough that the blankscreen temporarily would be concerning.
codecovbot commentedMay 4, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## main #1285 +/- ##==========================================- Coverage 66.29% 66.11% -0.19%========================================== Files 280 280 Lines 18389 18389 Branches 216 216 ==========================================- Hits 12191 12157 -34- Misses 4943 4969 +26- Partials 1255 1263 +8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lgtm
This splits our pages to use separate JavaScript bundles. Itinitially splits the terminal, which reduces our primarybundle size by ~400KB.We should do this for all pages, but that can come in a futurechange. This leaves the loading page empty for now, which Ithink is fine. None of our pages are large enough that the blankscreen temporarily would be concerning.
This splits our pages to use separate JavaScript bundles. It
initially splits the terminal, which reduces our primary
bundle size by ~400KB.
We should do this for all pages, but that can come in a future
change. This leaves the loading page empty for now, which I
think is fine. None of our pages are large enough that the blank
screen temporarily would be concerning.
#761