- Notifications
You must be signed in to change notification settings - Fork928
fix: Prefix paths in find on macOS#1284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This fixes paths not resolving in macOS, causingthe build target to fail. This also renames thesite target to specify the index.html, which isthe output artifact of building the site.
codecovbot commentedMay 4, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## main #1284 +/- ##==========================================- Coverage 66.20% 66.12% -0.09%========================================== Files 280 280 Lines 18389 18389 Branches 216 216 ==========================================- Hits 12174 12159 -15- Misses 4956 4969 +13- Partials 1259 1261 +2
Continue to review full report at Codecov.
|
| @@ -76,7 +76,7 @@ provisionersdk/proto/provisioner.pb.go: provisionersdk/proto/provisioner.proto | |||
| --go-drpc_opt=paths=source_relative\ | |||
| ./provisionersdk/proto/provisioner.proto | |||
| site/out:$(shell find ./site -not -path './site/node_modules/*' -type f -name '*.tsx')$(shell find ./site -not -path './site/node_modules/*' -type f -name '*.ts') site/package.json | |||
| site/out/index.html:$(shell find ./site -not -path './site/node_modules/*' -type f -name '*.tsx')$(shell find ./site -not -path './site/node_modules/*' -type f -name '*.ts') site/package.json | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could do something like this to not have to duplicate it twice
echo"*.tsx *.ts"| xargs -n1 find ./site -not -path'./site/node_modules/*' -type f -name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Auto-merge bites me yet again
This fixes paths not resolving in macOS, causingthe build target to fail. This also renames thesite target to specify the index.html, which isthe output artifact of building the site.
This fixes paths not resolving in macOS, causing
the build target to fail. This also renames the
site target to specify the index.html, which is
the output artifact of building the site.