Also can you please add a couple unit tests?

Unfortunately the cli golden file code (which is the only unit test that makes sense for formatting output) does not handle errors. This is because all cli tests invoke the command from within Go, skipping theerror handler.

You can see this is how we run it in a test:

Refactoring this will likely break a lot of cli tests since the goerror is more useful then it's text.

I do not want to add a new golden file test for this formatter in this PR. We can come back to testing if we really have formatting drift issues.

Edit: Just found an old issue I made:#11588. Exactly this.

I made it yellow though!

Edit: Just found an old issue I made:#11588. Exactly this.

@Emyrk given this is now in place, should we add a couple tests to it to encompass the new functionality?
I'm not so much worried about formatting errors as regressions; if we change the way we attach validation errors to thecodersdk.Error or some other transitive change, this will represent a degradation in UX on the CLI.

I made it yellow though!

Looks great! Thanks

@Emyrk given this is now in place, should we add a couple tests to it to encompass the new functionality? I'm not so much worried about formatting errors as regressions; if we change the way we attach validation errors to thecodersdk.Error or some other transitive change, this will represent a degradation in UX on the CLI.

Tests were added here. These cover all example errors, which covers the validation errors here. I'll rebase on main to get them.

#12698