Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

perf(coderd/database): optimizeGetWorkspaceAgentAndLatestBuildByAuthToken#12809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

mafredri
Copy link
Member

@mafredrimafredri commentedMar 28, 2024
edited
Loading

This query is run 35k/hour on dev.coder.com, this refactor lowers the execution time from 10ms to <0.2ms in my testing (against dev.coder.com DB) and should result in a bit less load.

Original:https://explain.dalibo.com/plan/ggdbc4b4dbeg6b1c
New:https://explain.dalibo.com/plan/ee87631976a2dh62

@mafredriGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@mafredri and the rest of your teammates onGraphiteGraphite

@mafredrimafredri marked this pull request as ready for reviewMarch 28, 2024 17:31
Copy link
Member

@kylecarbskylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

omg

Copy link
Contributor

@f0sself0ssel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I welcome any optimizations of my mediocre queries with open arms, thanks so much for finding and doing this.

mafredri reacted with heart emoji
@mafredrimafredri merged commit79441e3 intomainMar 28, 2024
@mafredrimafredri deleted the mafredri/03-28-perf_coderd_database_optimize_getworkspaceagentandlatestbuildbyauthtoken_ branchMarch 28, 2024 17:38
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 28, 2024
@mafredri
Copy link
MemberAuthor

It would seem this was a success:

image

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@kylecarbskylecarbskylecarbs approved these changes

@f0sself0sself0ssel approved these changes

@johnstcnjohnstcnAwaiting requested review from johnstcn

Assignees

@mafredrimafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@mafredri@kylecarbs@f0ssel

[8]ページ先頭

©2009-2025 Movatter.jp