- Notifications
You must be signed in to change notification settings - Fork1k
refactor: Move package.json and other front-end collateral into 'site'#128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| <Header | ||
| title={firstOrItem(project)} | ||
| description={firstOrItem(organization)} | ||
| title={firstOrItem(project,"")} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There were a couple places where the type-checks became stricter! I figured it was easier to leave them on in the stricter mode, and fix them, then to figure out how to turn them off
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yup, agreed!
codecovbot commentedFeb 1, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## main #128 +/- ##==========================================- Coverage 71.66% 70.54% -1.12%========================================== Files 92 96 +4 Lines 4168 4254 +86 Branches 59 68 +9 ==========================================+ Hits 2987 3001 +14- Misses 935 1010 +75+ Partials 246 243 -3
Continue to review full report at Codecov.
|
…139)Unfortunately along with#133 I missed one other item in moving files to `/site` in#128 - ignoring new configuration files (and other folders) in our `jest.config.js`.This caused our coverage numbers in front-end code to dip, because files that shouldn't be included (and previously weren't included) were now being tracked for coverage.
Hopefully the last thing I missed in#128 ... this fixes the `./develop.sh` script and `site/dev.ts` to account for the new pathing of `package.json`.
This refactors the front-end collateral to all live within
site- so nopackage.jsonat the root.The reason we had this initially is that the jest test run and NextJS actually require havingtwo different
tsconfigs - Next needsjsx:"preserve", while jest needsjsx:"react"- we were usingtsconfigs at different levels at the hierarchy to manage this.I changed this behavior to still use two different
tsconfig.jsons, which is mandatory - but just side-by-side insite.Once that's fixed, it was easy to move everything into
siteFollow up from:#118 (comment)