- Notifications
You must be signed in to change notification settings - Fork928
fix(coderd/database): add fk index forworkspace_agent_scripts#12791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
mafredri merged 1 commit intomainfrommafredri/03-28-fix_coderd_database_add_fk_index_for_workspace_agent_scripts_Mar 28, 2024
Merged
fix(coderd/database): add fk index forworkspace_agent_scripts#12791
mafredri merged 1 commit intomainfrommafredri/03-28-fix_coderd_database_add_fk_index_for_workspace_agent_scripts_Mar 28, 2024
+8 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite.Learn more about stacking. |
a64e13f tode32125CompareI noticed we were missing this index while looking at queryperformances, we were doing sequential scans on the table via the`GetWorkspaceAgentScriptsByAgentIDs` query, which is relatively fastwhilst the table is small, but at 8.5k calls/hour in our dogfoodinstance, it will become problematic eventually.
de32125 tof33ca15Comparemtojek approved these changesMar 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed we were missing this index while looking at query
performances, we were doing sequential scans on the table via the
GetWorkspaceAgentScriptsByAgentIDsquery, which is relatively fastwhilst the table is small, but at 8.5k calls/hour in our dogfood
instance, it will become problematic eventually.