Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: reduce azure CA cert validity check period to 2 months#12788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dannykopping merged 1 commit intocoder:mainfromdannykopping:dk/chill-az
Mar 28, 2024

Conversation

dannykopping
Copy link
Contributor

coderd/azureidentity/azureidentity_test.go:TestExpiresSoon is failing currently, because a few Azure certificates have not yet been renewed.

For example,Microsoft Azure TLS Issuing CA 01:

$ curl -s https://crt.sh/\?d\=2616326024| openssl x509 -in /dev/stdin -text| grep -e Validity -A2 -e Subject:            Validity            Not Before: Jan 17 20:22:47 2020 GMT            Not After: Jun 27 20:22:47 2024 GMT        Subject: C = US, O = Microsoft Corporation, CN = Microsoft Azure TLS Issuing CA 01        Subject Public Key Info:            Public Key Algorithm: rsaEncryption

Tagging@spikecurtis since you last changed this

Signed-off-by: Danny Kopping <danny@coder.com>
@spikecurtisGraphite App
Copy link
Contributor

Have they still not been replaced? Like, not just that they are expiring, but there is nothing to take their place?

@dannykopping
Copy link
ContributorAuthor

Have they still not been replaced? Like, not just that they are expiring, but there is nothing to take their place?

Not AFAICS onhttps://learn.microsoft.com/en-us/azure/security/fundamentals/azure-ca-details?tabs=root-and-subordinate-cas-list. At least, I just looked to see if the existing certs had been updated - I'm not sure if anything supersedes these.

@dannykoppingdannykopping merged commitd734f3f intocoder:mainMar 28, 2024
@dannykoppingdannykopping deleted the dk/chill-az branchMarch 28, 2024 09:17
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 28, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@spikecurtisspikecurtisspikecurtis approved these changes

Assignees

@dannykoppingdannykopping

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@dannykopping@spikecurtis
[8]ページ先頭
©2009-2025 Movatter.jp