Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs: describe single region and multi-region deployments#12779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mtojek merged 14 commits intomainfrom12429-deployments
Apr 3, 2024

Conversation

mtojek
Copy link
Member

@mtojekmtojek commentedMar 27, 2024•
edited
Loading

Related:#12429

Preview:https://github.com/coder/coder/blob/12429-deployments/docs/about/architecture.md

Changes:

  • Re-arrange sections in About/Architecture, components go first.
  • DescribeSingle region architecture
  • DescribeMulti-region architecture

@mtojekmtojek self-assigned thisMar 27, 2024
@mtojekmtojek mentioned this pull requestMar 28, 2024
6 tasks
@mtojekmtojek changed the titledocs: Describe single region and multi-region deploymentsdocs: describe single region and multi-region deploymentsMar 28, 2024
@mtojekmtojek marked this pull request as ready for reviewMarch 29, 2024 14:01
@mtojekmtojek requested a review frommafredriMarch 29, 2024 14:01
Copy link
Member

@ericpaulsenericpaulsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

made a few grammatical nits. other than that, looks great.

Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good job on writing these, had some nits, comments and questions, but in general looks great.

@mtojekmtojek requested a review frommafredriApril 2, 2024 13:41
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great 👍🏻

@mtojekmtojek merged commitac8d1c6 intomainApr 3, 2024
@mtojekmtojek deleted the 12429-deployments branchApril 3, 2024 10:45
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 3, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri approved these changes

@ericpaulsenericpaulsenAwaiting requested review from ericpaulsen

Assignees

@mtojekmtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@mtojek@mafredri@ericpaulsen
[8]ページ先頭
©2009-2025 Movatter.jp