Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: always use bash when executing web terminal tests#12755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 1 commit intomainfromfix-leaky-terminal-test
Mar 25, 2024

Conversation

aslilac
Copy link
Member

No description provided.

@aslilacaslilacforce-pushed thefix-leaky-terminal-test branch from54a3715 to237a5d1CompareMarch 25, 2024 21:43
Copy link
Member

@kylecarbskylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We might want to instead grab the link from that button, modify it with the query parameter, then click it.

Right now, this is technically executing two terminal sessions.

@aslilac
Copy link
MemberAuthor

aslilac commentedMar 25, 2024
edited
Loading

We might want to instead grab the link from that button, modify it with the query parameter, then click it.

I thought about that, but I'm not crazy about the feeling of reaching into the app, making changes from the outside, and then using this newly tweaked behavior as the one that we test. 😅 Feels a bit too much like we're not testing the button anymore.

Also it doesn't even look like that's something that Playwright supports, but I might not be seeing something. I guess you can useevaluateHandle but that just further signals to me that this isn't a thing you're intended to do.

@aslilac
Copy link
MemberAuthor

I tried it anyway just to see, and something is getting lost in translation.

// This assertion passes, everything seems fine.expect(awaitpage.getByTestId("terminal").getAttribute("href")).toBe(`/@admin/${workspaceName}.dev/terminal${commandQuery}`,);// This one does not. Somehow, the change isn't _actually_ taking effect, even though it seems to be reflected.awaitexpect(terminal).toHaveURL(`/@admin/${workspaceName}.dev/terminal${commandQuery}`,);

...so I'm just gonna go with the way it is. 😅

@aslilacaslilac merged commitcfb484f intomainMar 25, 2024
@aslilacaslilac deleted the fix-leaky-terminal-test branchMarch 25, 2024 22:58
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 25, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@kylecarbskylecarbskylecarbs approved these changes

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@aslilac@kylecarbs

[8]ページ先頭

©2009-2025 Movatter.jp