- Notifications
You must be signed in to change notification settings - Fork928
test(coderd): fix todo for increased accuracy in insights test#12727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
mafredri merged 1 commit intomainfrommafredri/03-22-test_coderd_fix_todo_for_increased_accuracy_in_insights_testMar 25, 2024
Merged
test(coderd): fix todo for increased accuracy in insights test#12727
mafredri merged 1 commit intomainfrommafredri/03-22-test_coderd_fix_todo_for_increased_accuracy_in_insights_testMar 25, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedMar 22, 2024
MemberAuthor
mafredri commentedMar 22, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
3cd22e7 to2eb4bd7Compare878d0b3 to6eca349Compare2eb4bd7 tof43a8b1Compare6eca349 to7eb4477Comparef43a8b1 toe547a2dCompare7eb4477 to55e2d64Comparee547a2d to3e810fbCompare55e2d64 toa4237e8Compare3e810fb to601e4f9Comparea4237e8 toa20a9f6Compare601e4f9 to1d60b49Comparea20a9f6 toc08e2f7Compare1d60b49 to407eff8Comparec08e2f7 to7e9a5c9Compare407eff8 to138046bCompare7e9a5c9 to7e90441Compare138046b toe518ad5Compare7e90441 toa9fadb5Comparee518ad5 to11d9293Comparea9fadb5 to9573615Compare11d9293 to1d53faeComparemtojek approved these changesMar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
MemberAuthor
mafredri commentedMar 25, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Merge activity
|
johnstcn approved these changesMar 25, 2024
9573615 to72f2404Compare Base automatically changed frommafredri/rewrite-gettemplateinsightsbytemplate tomainMarch 25, 2024 15:42
1d53fae to4eede5fCompareSign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR updates the tests in
insights_test.goto enable commented-out scenarios. This behavior was fixed by previous PRs in this stack. Note that the updated golden files are correct since they are "second template only" meaning that the newly introduced data is considered as expected. In other golden files there is no change since "only count once" is applied.