Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: add api specific 404#1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
coadler merged 1 commit intomainfromcolin/api-404
May 3, 2022
Merged

chore: add api specific 404#1272

coadler merged 1 commit intomainfromcolin/api-404
May 3, 2022

Conversation

coadler
Copy link
Contributor

Prevents weird errors when routes are moved, like
#1205

Prevents weird errors when routes are moved, like#1205
@coadlercoadler self-assigned thisMay 3, 2022
@coadlercoadler requested a review fromkylecarbsMay 3, 2022 14:14
@codecov
Copy link

codecovbot commentedMay 3, 2022
edited
Loading

Codecov Report

Merging#1272 (694cff8) intomain (eda85a0) willdecrease coverage by0.19%.
The diff coverage is16.66%.

@@            Coverage Diff             @@##             main    #1272      +/-   ##==========================================- Coverage   66.09%   65.90%   -0.20%==========================================  Files         277      277                Lines       18226    18230       +4       Branches      216      216              ==========================================- Hits        12047    12015      -32- Misses       4934     4962      +28- Partials     1245     1253       +8
FlagCoverage Δ
unittest-go-macos-latest53.26% <16.66%> (-0.20%)⬇️
unittest-go-postgres-64.84% <16.66%> (-0.09%)⬇️
unittest-go-ubuntu-latest55.78% <16.66%> (+0.10%)⬆️
unittest-go-windows-202251.66% <16.66%> (+0.03%)⬆️
unittest-js70.69% <ø> (ø)
Impacted FilesCoverage Δ
coderd/coderd.go95.57% <16.66%> (-2.16%)⬇️
peer/channel.go84.21% <0.00%> (-2.50%)⬇️
peer/conn.go80.58% <0.00%> (-2.22%)⬇️
cli/cliui/provisionerjob.go76.42% <0.00%> (-2.15%)⬇️
agent/agent.go65.90% <0.00%> (-1.86%)⬇️
coderd/workspaceagents.go57.90% <0.00%> (-0.94%)⬇️
provisionerd/provisionerd.go76.17% <0.00%> (-0.54%)⬇️
peerbroker/listen.go87.39% <0.00%> (ø)
provisioner/terraform/provision.go72.30% <0.00%> (+0.40%)⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updateeda85a0...694cff8. Read thecomment docs.

@coadlercoadler merged commite530ab2 intomainMay 3, 2022
@coadlercoadler deleted the colin/api-404 branchMay 3, 2022 14:22
@missknissmisskniss added this to theV2 Beta milestoneMay 15, 2022
kylecarbs pushed a commit that referenced this pull requestJun 10, 2022
Prevents weird errors when routes are moved, like#1205
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kylecarbskylecarbskylecarbs approved these changes

Assignees

@coadlercoadler

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

3 participants
@coadler@kylecarbs@misskniss

[8]ページ先頭

©2009-2025 Movatter.jp