Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(cli/support): confirm before creating bundle#12684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 6 commits intomainfromcj/support-confirm
Mar 21, 2024

Conversation

johnstcn
Copy link
Member

@johnstcnjohnstcn commentedMar 20, 2024•
edited
Loading

Last must-haves of#12163

Forces user to confirm before creating a support bundle.
Also adds contextual information to the bundle undercli_logs.txt.
Finally, un-hides thesupport command`. EDIT: will un-hide closer to release.

@johnstcnjohnstcn self-assigned thisMar 20, 2024
Comment on lines 82 to 84
cliLog.Info(inv.Context(), "user confirmed manually", slog.F("answer", ans))
} else {
cliLog.Info(inv.Context(), "user auto-confirmed")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nit: debug or trace level?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah fair, we don't want unnecessary output.

}

// Check if we're running inside a workspace
if val, found := os.LookupEnv("CODER"); found && val == "true" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nit: maybe create a util function for this?

@johnstcnjohnstcn merged commitf2a9e51 intomainMar 21, 2024
@johnstcnjohnstcn deleted the cj/support-confirm branchMarch 21, 2024 17:06
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 21, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mtojekmtojekmtojek left review comments

@mafredrimafredrimafredri approved these changes

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@johnstcn@mafredri@mtojek
[8]ページ先頭
©2009-2025 Movatter.jp