NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

fix: force logs to flush on close in peer.(*Conn)#1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

coadler merged 3 commits intomainfromcolin/peer-log

May 3, 2022

Merged

fix: force logs to flush on close in peer.(*Conn)#1268

coadler merged 3 commits intomainfromcolin/peer-log

May 3, 2022

Conversation

Copy link

Contributor

coadler commentedMay 3, 2022

No description provided.

fix: force logs to flush on close in peer.(*Conn)

8875b2f

coadler self-assigned this

May 3, 2022

coadler requested a review fromkylecarbs

May 3, 2022 13:29

coadler added2 commits

May 3, 2022 08:29

fixup! fix: force logs to flush on close in peer.(*Conn)

f38c771

fixup! fix: force logs to flush on close in peer.(*Conn)

4e9dab4

Copy link

codecovbot commentedMay 3, 2022•
edited
Loading

Codecov Report

Merging#1268 (4e9dab4) intomain (5dcaf94) willdecrease coverage by0.35%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##             main    #1268      +/-   ##==========================================- Coverage   66.10%   65.75%   -0.36%==========================================  Files         276      273       -3       Lines       18146    18026     -120       Branches      216      216              ==========================================- Hits        11996    11853     -143- Misses       4911     4931      +20- Partials     1239     1242       +3

Flag	Coverage Δ
unittest-go-macos-latest	`53.31% <100.00%> (+0.10%)`	⬆️
unittest-go-postgres-	`64.77% <100.00%> (-0.34%)`	⬇️
unittest-go-ubuntu-latest	`55.79% <100.00%> (+0.03%)`	⬆️
unittest-go-windows-2022	`?`
unittest-js	`70.69% <ø> (ø)`

Impacted Files	Coverage Δ
peer/conn.go	`79.85% <100.00%> (-1.74%)`	⬇️
cli/configssh.go	`62.04% <0.00%> (-6.57%)`	⬇️
peerbroker/dial.go	`77.04% <0.00%> (-6.56%)`	⬇️
codersdk/provisionerdaemons.go	`61.97% <0.00%> (-5.64%)`	⬇️
pty/ptytest/ptytest.go	`86.95% <0.00%> (-4.35%)`	⬇️
cli/templateinit.go	`58.62% <0.00%> (-3.45%)`	⬇️
peerbroker/listen.go	`84.03% <0.00%> (-3.37%)`	⬇️
agent/agent.go	`64.66% <0.00%> (-2.48%)`	⬇️
provisionerd/provisionerd.go	`75.76% <0.00%> (-2.41%)`	⬇️
cli/cliui/provisionerjob.go	`76.42% <0.00%> (-2.15%)`	⬇️
... and13 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update5dcaf94...4e9dab4. Read thecomment docs.