- Notifications
You must be signed in to change notification settings - Fork928
feat(coderd/database): usetemplate_usage_stats inGetUserLatencyInsights query#12671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedMar 19, 2024
MemberAuthor
mafredri commentedMar 19, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This was referencedMar 19, 2024
db6c026 to59c0a23Compareb1e5d1a toc0b0216Comparejohnstcn approved these changesMar 20, 2024
59c0a23 todb40db5Comparec0b0216 to1793acbComparecodersdk/insights.go Outdated
| @@ -98,7 +98,8 @@ type UserActivity struct { | |||
| // ConnectionLatency shows the latency for a connection. | |||
| type ConnectionLatency struct { | |||
| P50 float64 `json:"p50" example:"31.312"` | |||
| P95 float64 `json:"p95" example:"119.832"` | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is this change intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It was, but I reverted it. (It was based on a discussion in Slack where p90/p99 would be preferable over p95, and since this p95 isn't used anywhere, the change would be harmless, but this is not the right place for it.)
db40db5 to689d1c9Compare1793acb to91d960fCompare689d1c9 to6d96a3eCompare91d960f to83f3b78Compare6d96a3e to754d6c1Compare83f3b78 to2947a31Compareef0f1bc toa6a8055Compare2947a31 toda749aeComparea6a8055 to23cf1c6Compareda749ae to6027088Compare23cf1c6 tob11b3b6Compare6027088 toe0f339cComparee0f339c toe66ae18Compare87f22f1 to2cf5f94Comparee66ae18 to150df95Compare2cf5f94 to02d0f24Compare150df95 to11efd8bCompare02d0f24 todfa069bCompare11efd8b to92a0a25Comparedfa069b to6fca988Compare92a0a25 toac22243Compare6fca988 to0cd1f85Compareac22243 toc5457d4CompareGetUserLatencyInsights to usetemplate_usage_statstemplate_usage_stats inGetUserLatencyInsights query0cd1f85 to549a837Comparec5457d4 to48b0729Comparekylecarbs approved these changesMar 25, 2024
mtojek approved these changesMar 25, 2024
MemberAuthor
mafredri commentedMar 25, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
549a837 to6813b73Compare7750bb6 to438d3a9CompareSign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR updates the
GetUserLatencyInsightsquery to use rolled uptemplate_usage_statsinstead of raw agent and app stats.