NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

fix: additional provisionerd test double closes#1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

coadler merged 2 commits intomainfromcolin/pd-double-close

May 3, 2022

Merged

fix: additional provisionerd test double closes#1267

coadler merged 2 commits intomainfromcolin/pd-double-close

May 3, 2022

Conversation

Copy link

Contributor

coadler commentedMay 3, 2022

https://github.com/coder/coder/runs/6266376800?check_suite_focus=true

fix: additional provisionerd test double closes

20c05f8

https://github.com/coder/coder/runs/6266376800?check_suite_focus=true

coadler self-assigned this

May 3, 2022

kylecarbs approved these changes

May 3, 2022

View reviewed changes

Copy link

codecovbot commentedMay 3, 2022•
edited
Loading

Codecov Report

Merging#1267 (356db63) intomain (5dcaf94) willdecrease coverage by0.18%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #1267      +/-   ##==========================================- Coverage   66.10%   65.92%   -0.19%==========================================  Files         276      276                Lines       18146    18146                Branches      216      216              ==========================================- Hits        11996    11963      -33- Misses       4911     4935      +24- Partials     1239     1248       +9

Flag	Coverage Δ
unittest-go-macos-latest	`53.14% <ø> (-0.07%)`	⬇️
unittest-go-postgres-	`64.84% <ø> (-0.28%)`	⬇️
unittest-go-ubuntu-latest	`55.67% <ø> (-0.09%)`	⬇️
unittest-go-windows-2022	`51.49% <ø> (-0.04%)`	⬇️
unittest-js	`70.69% <ø> (ø)`

Impacted Files	Coverage Δ
peerbroker/dial.go	`77.04% <0.00%> (-6.56%)`	⬇️
codersdk/provisionerdaemons.go	`61.97% <0.00%> (-5.64%)`	⬇️
provisionerd/provisionerd.go	`76.17% <0.00%> (-2.01%)`	⬇️
agent/agent.go	`65.90% <0.00%> (-1.24%)`	⬇️
coderd/workspaceagents.go	`56.04% <0.00%> (-0.94%)`	⬇️
peer/channel.go	`84.39% <0.00%> (-0.58%)`	⬇️
provisioner/terraform/provision.go	`71.89% <0.00%> (-0.41%)`	⬇️
peerbroker/listen.go	`87.39% <0.00%> (ø)`
peer/conn.go	`82.33% <0.00%> (+0.74%)`	⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update5dcaf94...356db63. Read thecomment docs.