- Notifications
You must be signed in to change notification settings - Fork928
feat(coderd/database): usetemplate_usage_stats inGetTemplateAppInsights query#12669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedMar 19, 2024
MemberAuthor
mafredri commentedMar 19, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This was referencedMar 19, 2024
f369461 to2eae8f8Compare7fa004c tod384842Comparejohnstcn approved these changesMar 20, 2024
2eae8f8 to4ae3521Compared384842 toc10b34bComparemtojek approved these changesMar 20, 2024
| wa.agent_id = was.agent_id | ||
| AND wa.slug = was.slug_or_port | ||
| WITH | ||
| app_insights AS ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
nit: you may want to drop a comment here, many joins around
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hmm, in my opinion it's a self-contained sequence of joins and there is a comment inline, is there something more you would like explained in the comment? This is a common pattern when we need to lookup agent (or in our case app) -> template association.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah, exactly this :)
prevent going through joins and "fast-forward" reading query code by human
4ae3521 to2ac8855Comparec10b34b toc45caebCompareeb52bb7 to37f6f3aComparec45caeb tod481905Compare37f6f3a to70ba902Compare3d14fe4 to04b5c07Compare70ba902 to4d27721Compare11871be to8a9eb15Compare4d27721 to53a54b0Compare8a9eb15 to772aa60Compare772aa60 to460c244Comparea234c5d to02b3828Compare460c244 to87f22f1Compare958785d to05780dbCompare2cf5f94 to02d0f24Compare05780db to3c67005Compare02d0f24 todfa069bCompare3c67005 tobf27a9fComparedfa069b to6fca988Comparebf27a9f to8b32a8cCompare6fca988 to0cd1f85CompareGetTemplateAppInsights to usetemplate_usage_statstemplate_usage_stats inGetTemplateAppInsights query8b32a8c tobfe4b8aCompare0cd1f85 to549a837CompareMemberAuthor
mafredri commentedMar 25, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
bfe4b8a tocb74f29Compare Base automatically changed frommafredri/rewrite-gettemplateinsightsbyinterval tomainMarch 25, 2024 13:45
549a837 to6813b73CompareSign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR updates the
GetTemplateAppInsightsquery to use rolled uptemplate_usage_statsinstead of raw agent and app stats.