- Notifications
You must be signed in to change notification settings - Fork928
feat(coderd/database): usetemplate_usage_stats inGetTemplateInsights query#12666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
MemberAuthor
mafredri commentedMar 19, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This was referencedMar 19, 2024
Closed
6364b79 todcc3811Compare45217ba to3651195Comparejohnstcn approved these changesMar 20, 2024
dcc3811 to7fc6fb5Compare3651195 to454f328Comparemtojek approved these changesMar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nothing concerning here
7fc6fb5 to91fb8e4Compare454f328 to1e05111Compareb915c4c toa083bc9Compareb9c85a5 to2d7344aComparea083bc9 to97c9a10Compare2d7344a to3b66babCompare97c9a10 toa9d5ab0Compare3b66bab todbe21aaComparea9d5ab0 tof2200fbComparedbe21aa tob499ab2Compare| "template_ids": [ | ||
| "00000000-0000-0000-0000-000000000002" | ||
| ], | ||
| "template_ids": [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
These template ID changes in app usage is due to improved correctness.
f2200fb to3101fbaCompareb499ab2 tob208047Compare3101fba toc9bd6afCompareb208047 to4da99d8Comparec9bd6af toc08f934Compare4da99d8 to33c681fComparec08f934 to22f614eCompare33c681f to5c7ed09Compare22f614e to0f423a2Compare5c7ed09 to7e229d3Compare0f423a2 to60d812dCompare7e229d3 tob46a8e0Compareda902a8 to9c2d085Compareb46a8e0 to87ab396Compare Base automatically changed frommafredri/fix-insights-tests-after-refactor tomainMarch 22, 2024 18:18
GetTemplateInsights to usetemplate_usage_statstemplate_usage_stats inGetTemplateInsights query87ab396 to49acc52CompareMemberAuthor
mafredri commentedMar 25, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR updates the
GetTemplateInsightsquery to use rolled uptemplate_usage_statsinstead of raw agent and app stats.