Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(coderd/database): addtemplate_usage_stats table and rollup query#12664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

mafredri
Copy link
Member

@mafredrimafredri commentedMar 19, 2024•
edited
Loading

This PR adds a new table,template_usage_stats containing aggregate usage data from users and what features they've used.

The rollup is performed by theUpsertTemplateUsageStats query and it fetches data from theworkspace_agent_stats andworkspace_app_stats tables.

@mafredriGraphite App
Copy link
MemberAuthor

mafredri commentedMar 19, 2024•
edited
Loading

This was referencedMar 19, 2024
@mafredrimafredriforce-pushed themafredri/add-template-usage-stats-table-and-rollup-query branch from5a49791 toc9fe7c5CompareMarch 19, 2024 16:24
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't have any blocking comments here, except for the potential of a golden-style test for this query. Will approve once CI is happy 👍 Nice work!

@mafredri
Copy link
MemberAuthor

I don't have any blocking comments here, except for the potential of a golden-style test for this query. Will approve once CI is happy 👍 Nice work!

Thanks for the review. The golden file verifications will come via existing tests in:#12673

(Although I'm planning on moving that PR around a bit in this stack.)

@mafredrimafredriforce-pushed themafredri/add-template-usage-stats-table-and-rollup-query branch fromc9fe7c5 to46bc0f0CompareMarch 20, 2024 10:25
@mafredrimafredriforce-pushed themafredri/add-template-usage-stats-table-and-rollup-query branch 2 times, most recently fromb64c291 tob3bdea2CompareMarch 20, 2024 13:56
@mafredrimafredriforce-pushed themafredri/add-template-usage-stats-table-and-rollup-query branch fromdf37ae9 tocafcc7bCompareMarch 20, 2024 19:03
@mafredrimafredriforce-pushed themafredri/add-template-usage-stats-table-and-rollup-query branch from8f207e3 to310f545CompareMarch 20, 2024 19:55
@mafredrimafredri marked this pull request as ready for reviewMarch 20, 2024 20:05
@mafredrimafredriforce-pushed themafredri/add-template-usage-stats-table-and-rollup-query branch 2 times, most recently fromfc0b87c tocba0c08CompareMarch 21, 2024 17:53
@mafredrimafredriforce-pushed themafredri/add-template-usage-stats-table-and-rollup-query branch fromcba0c08 to8b96a59CompareMarch 22, 2024 15:40
@mafredriGraphite App
Copy link
MemberAuthor

mafredri commentedMar 22, 2024•
edited
Loading

Merge activity

@mafredrimafredri merged commit04f0510 intomainMar 22, 2024
@mafredrimafredri deleted the mafredri/add-template-usage-stats-table-and-rollup-query branchMarch 22, 2024 16:33
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 22, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn left review comments

@mtojekmtojekmtojek approved these changes

Assignees

@mafredrimafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@mafredri@johnstcn@mtojek
[8]ページ先頭
©2009-2025 Movatter.jp