NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

feat: add pprof and prometheus metrics to`coder server`#1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

coadler merged 3 commits intomainfromcolin/prom-pprof

May 3, 2022

Merged

feat: add pprof and prometheus metrics to`coder server`#1266

coadler merged 3 commits intomainfromcolin/prom-pprof

May 3, 2022

Conversation

Copy link

Contributor

coadler commentedMay 2, 2022

No description provided.

feat: add pprof and prometheus metrics tocoder server

67eee75

coadler self-assigned this

May 2, 2022

coadler requested a review fromkylecarbs

May 2, 2022 23:15

Copy link

codecovbot commentedMay 2, 2022•
edited
Loading

Codecov Report

Merging#1266 (dca1216) intomain (fd49a18) willdecrease coverage by0.27%.
The diff coverage is74.35%.

@@            Coverage Diff             @@##             main    #1266      +/-   ##==========================================- Coverage   66.07%   65.79%   -0.28%==========================================  Files         276      277       +1       Lines       18146    18221      +75       Branches      216      216              ==========================================- Hits        11990    11989       -1- Misses       4917     4976      +59- Partials     1239     1256      +17

Flag	Coverage Δ
unittest-go-macos-latest	`53.27% <74.35%> (+0.13%)`	⬆️
unittest-go-postgres-	`64.75% <74.35%> (-0.17%)`	⬇️
unittest-go-ubuntu-latest	`55.71% <74.35%> (-0.02%)`	⬇️
unittest-go-windows-2022	`51.61% <74.35%> (+0.15%)`	⬆️
unittest-js	`70.69% <ø> (ø)`

Impacted Files	Coverage Δ
cli/server.go	`57.59% <37.93%> (-1.20%)`	⬇️
coderd/httpmw/prometheus.go	`95.45% <95.45%> (ø)`
coderd/coderd.go	`97.72% <100.00%> (+0.04%)`	⬆️
peerbroker/dial.go	`77.04% <0.00%> (-13.12%)`	⬇️
coderd/parameter/compute.go	`74.07% <0.00%> (-4.45%)`	⬇️
peerbroker/proxy.go	`58.72% <0.00%> (-3.49%)`	⬇️
provisioner/echo/serve.go	`56.80% <0.00%> (-2.41%)`	⬇️
cli/cliui/provisionerjob.go	`76.42% <0.00%> (-2.15%)`	⬇️
peer/conn.go	`76.86% <0.00%> (-1.75%)`	⬇️
provisionerd/provisionerd.go	`75.23% <0.00%> (-1.48%)`	⬇️
... and4 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatefd49a18...dca1216. Read thecomment docs.

kylecarbs approved these changes

May 2, 2022

View reviewed changes

Copy link

Member

kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I like how simple this is. Neato!

cli/server.go Outdated

		cliflag.StringVarP(root.Flags(), &address, "address", "a", "CODER_ADDRESS", "127.0.0.1:3000", "The address to serve the API and dashboard")
		cliflag.StringVarP(root.Flags(), &accessURL, "access-url", "", "CODER_ACCESS_URL", "", "Specifies the external URL to access Coder.")
		cliflag.StringVarP(root.Flags(), &address, "address", "a", "CODER_ADDRESS", "127.0.0.1:3000", "The address to serve the API and dashboard.")
		cliflag.BoolVarP(root.Flags(), &promEnabled, "enable-prometheus", "", "CODER_ENABLE_PROMETHEUS", false, "Enable serving prometheus metrics on the addressdefined by --prometheus-address.")