Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(cli): port-forward: update workspace last_used_at#12659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 21 commits intomainfromcj/cli-workspace-heartbeat
Mar 20, 2024
Merged
Changes from1 commit
Commits
Show all changes
21 commits
Select commitHold shift + click to select a range
279f874
add tests to assert last used at updated on port-forward
johnstcnMar 18, 2024
8f9b945
add workspaceusage package
johnstcnMar 18, 2024
e8c842c
add workspace usager tracking to coderd, add endpoint
johnstcnMar 18, 2024
86704a1
add workspace usage tracking to cli/portforward, fix tests
johnstcnMar 19, 2024
c99327c
make gen
johnstcnMar 19, 2024
5876edd
workspaceusage: improve locking and tests
johnstcnMar 19, 2024
e4e0311
address more PR comments
johnstcnMar 19, 2024
958d1d1
try to race harder
johnstcnMar 19, 2024
a36aeb9
add danny's suggestions
johnstcnMar 20, 2024
692f666
add big big comments
johnstcnMar 20, 2024
d794e00
fix(database): BatchUpdateWorkspaceLastUsedAt: avoid overwriting olde…
johnstcnMar 20, 2024
45a0eef
fix(coderd/workspaceusage): log number of consecutive flush errors
johnstcnMar 20, 2024
8e40efd
upgrade to error log on multiple flush failures
johnstcnMar 20, 2024
591e1ab
chore(coderd/workspaceusage): add integration-style test with multipl…
johnstcnMar 20, 2024
0caaf3a
fix(cli/portforward_test.go): use testutil.RequireRecv/SendCtx
johnstcnMar 20, 2024
cc72868
just use default flush interval
johnstcnMar 20, 2024
f5f8d75
rename receiver
johnstcnMar 20, 2024
a2e716d
defer close doneCh
johnstcnMar 20, 2024
5b64f96
defer instead of cleanup, avoid data race in real pubsub
johnstcnMar 20, 2024
23ccf21
fix(coderdtest): buffer just in case
johnstcnMar 20, 2024
c9ac9d2
refactor: unexport Loop, remove panic, simplify external API
johnstcnMar 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
defer close doneCh
  • Loading branch information
@johnstcn
johnstcn committedMar 20, 2024
commita2e716d73d25b34abf1e8d15636debe63568e204
2 changes: 1 addition & 1 deletioncoderd/workspaceusage/tracker.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -169,12 +169,12 @@ func (tr *Tracker) Loop() {
default:
}
defer func() {
close(tr.doneCh)
tr.log.Debug(context.Background(), "workspace usage tracker loop exited")
}()
for {
select {
case <-tr.stopCh:
close(tr.doneCh)
return
case now, ok := <-tr.tickCh:
if !ok {
Expand Down

[8]ページ先頭

©2009-2025 Movatter.jp