- Notifications
You must be signed in to change notification settings - Fork928
fix(cli): port-forward: update workspace last_used_at#12659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
21 commits Select commitHold shift + click to select a range
279f874
add tests to assert last used at updated on port-forward
johnstcn8f9b945
add workspaceusage package
johnstcne8c842c
add workspace usager tracking to coderd, add endpoint
johnstcn86704a1
add workspace usage tracking to cli/portforward, fix tests
johnstcnc99327c
make gen
johnstcn5876edd
workspaceusage: improve locking and tests
johnstcne4e0311
address more PR comments
johnstcn958d1d1
try to race harder
johnstcna36aeb9
add danny's suggestions
johnstcn692f666
add big big comments
johnstcnd794e00
fix(database): BatchUpdateWorkspaceLastUsedAt: avoid overwriting olde…
johnstcn45a0eef
fix(coderd/workspaceusage): log number of consecutive flush errors
johnstcn8e40efd
upgrade to error log on multiple flush failures
johnstcn591e1ab
chore(coderd/workspaceusage): add integration-style test with multipl…
johnstcn0caaf3a
fix(cli/portforward_test.go): use testutil.RequireRecv/SendCtx
johnstcncc72868
just use default flush interval
johnstcnf5f8d75
rename receiver
johnstcna2e716d
defer close doneCh
johnstcn5b64f96
defer instead of cleanup, avoid data race in real pubsub
johnstcn23ccf21
fix(coderdtest): buffer just in case
johnstcnc9ac9d2
refactor: unexport Loop, remove panic, simplify external API
johnstcnFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
defer close doneCh
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commita2e716d73d25b34abf1e8d15636debe63568e204
There are no files selected for viewing
2 changes: 1 addition & 1 deletioncoderd/workspaceusage/tracker.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.