- Notifications
You must be signed in to change notification settings - Fork928
feat(coderd): export metric indicating each experiment's status#12657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
5 commits Select commitHold shift + click to select a range
62c0551
Export metric indicating each experiment's status
dannykoppingc93e4e2
Test metric name
dannykopping6f351d7
Ignore gocognit lint error for now
dannykopping50ccb7c
Apply suggestions from code review
dannykopping11abaa6
Review comments, expanding tests
dannykoppingFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Test metric name
Signed-off-by: Danny Kopping <danny@coder.com>
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commitc93e4e23c5a5c847a5691fc7dda7eb4d2dec931e
There are no files selected for viewing
3 changes: 2 additions & 1 deletioncli/cliui/provisionerjob_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletionscoderd/prometheusmetrics/prometheusmetrics_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -525,6 +525,8 @@ func TestExperimentsMetric(t *testing.T) { | ||
require.Lenf(t, out, 1, "unexpected number of registered metrics") | ||
for _, metric := range out[0].GetMetric() { | ||
dannykopping marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
require.Equal(t, "coderd_experiments", out[0].GetName()) | ||
labels := metric.GetLabel() | ||
require.Lenf(t, labels, 1, "unexpected number of labels") | ||
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.