- Notifications
You must be signed in to change notification settings - Fork928
feat(coderd): export metric indicating each experiment's status#12657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Signed-off-by: Danny Kopping <danny@coder.com>
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Feel free to raise the linter limit a bit to avoid the gocognit issue. This is best adressed in a follow up PR but isn’t critical.
Except for a few nits looks good otherwise.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
Signed-off-by: Danny Kopping <danny@coder.com>
| var active codersdk.Experiments | ||
| for _, exp := range options.DeploymentValues.Experiments.Value() { | ||
| active = append(active, codersdk.Experiment(exp)) | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is fine, but optionally to keep it cleaner, you could move this tocodersdk, something likecodersdk.ExperimentsFromString(Value()...).
Relates to#12070
Exposes a metric indicating which experiments are active/inactive.
I chose to expose the experiments that are not active as well because this will allow operators to get the same view in metrics as what we expose in the frontend.